#######################################################################

                             Luigi Auriemma

Application:  White_Dune
              http://vrml.cip.ica.uni-stuttgart.de/dune/
Versions:     <= 0.29beta791
Platforms:    Unix/Linux/MacOSX and Windows
Bugs:         A] buffer-overflow in Scene::errorf
              B] format string in ImportFile
Exploitation: local
Date:         02 Jan 2008
Author:       Luigi Auriemma
              e-mail: aluigi@autistici.org
              web:    aluigi.org


#######################################################################


1) Introduction
2) Bugs
3) The Code
4) Fix


#######################################################################

===============
1) Introduction
===============


White_Dune is an open source editor/viewer for the VRML97 files.


#######################################################################

=======
2) Bugs
=======

-----------------------------------
A] buffer-overflow in Scene::errorf
-----------------------------------

A buffer-overflow vulnerability is located in the function which builds
the error messages for the problems happened during the parsing of the
WRL file.

>From Scene.cpp:

void
Scene::errorf(const char *fmt, ...)
{
    va_list ap;
    char buf[1024], buf2[1024];
    const char *url = "";  

    va_start(ap, fmt);
    vsprintf(buf, fmt, ap);
    if (TheApp->getImportURL() != NULL)
        url = TheApp->getImportURL();
    mysnprintf(buf2, 1024, "%s %d: %s", url, lineno, buf);
    _compileErrors += buf2;
}


------------------------------
B] format string in ImportFile
------------------------------

Another problem related to the handling of the errors.
After the building of the error message the parse() function returns
immediately and swDebugf() is called for visualizing it to stderr or to
the debugger without using the needed format argument required by the
function.

>From DuneApp.cpp:

DuneApp::ImportFile(const char *openpath, Scene* scene, bool protoLibrary,
                    Node *node, int field)
    ...
    if (errors[0]) {
        swMessageBox(_mainWnd, errors, "Parse Errors", SW_MB_OK, SW_MB_WARNING);
        swDebugf(errors);
        ...


#######################################################################

===========
3) The Code
===========


http://aluigi.org/poc/whitedunboffs.zip


#######################################################################

======
4) Fix
======


Version 0.29beta795


#######################################################################


--- 
Luigi Auriemma
http://aluigi.org

 
 
 

 


Mobile : 
Email  : 
Web   : http://www.sd.zain.com/
--------------------------------------------------------------------------
 

--------------------------------------------------------------------------
Disclaimer

This communication is intended for the above named person and is confidential and / or legally privileged. Any opinion(s) expressed in this communication are not necessarily those of the Zain. If it has come to you in error you must take no action based upon it, nor must you print it, copy it, forward it, or show it to anyone. Please delete and destroy the e-mail and any attachments and inform the sender immediately. Thank you.
Zain is not responsible for the political, religious, racial or partisan opinion in any correspondence conducted by its domain users. Therefore, any such opinion expressed, whether explicitly or implicitly, in any said correspondence is not to be interpreted as that of Zain.
Zain may monitor all incoming and outgoing e-mails in line with Zain business practice. Although Zain has taken steps to ensure that e-mails and attachments are free from any virus, we advise that, in keeping with best business practice, the recipient must ensure they are actually virus free.
"