what you don't know can hurt you

Broadcom wl_iw_get_essid Heap Overflow

Broadcom wl_iw_get_essid Heap Overflow
Posted Apr 9, 2017
Authored by Google Security Research, laginimaineb

Broadcom suffers from a heap overflow vulnerability in wl_iw_get_essid when handling WLC_GET_SSID ioctl results.

tags | advisory, overflow
advisories | CVE-2017-0570
MD5 | 049106b14cc8169436d7ad3887a23d6f

Broadcom wl_iw_get_essid Heap Overflow

Change Mirror Download
 Broadcom: Heap overflow in "wl_iw_get_essid" when handling WLC_GET_SSID ioctl results 

CVE-2017-0570


Broadcom produces Wi-Fi HardMAC SoCs which are used to handle the PHY and MAC layer processing. These chips are present in both mobile devices and Wi-Fi routers, and are capable of handling many Wi-Fi related events without delegating to the host OS. On Android devices, the "bcmdhd" driver is used in order to communicate with the Wi-Fi SoC (also referred to as "dongle").

Along with the regular flow of frames transferred between the host and the dongle, the two communicate with one another via a set of "ioctls" which can be issued to read or write dongle configuration from the host. This information is exchanged using the SDIO "control" channel (SDPCM_CONTROL_CHANNEL) rather than the regular "data" and "glom" channels (which are used to transfer frames).

"bcmdhd" registers a set of handlers to support IW ioctls (which may be invoked on a socket descriptors where "iwreq.ifrname" points to a device entry exposed by the "bcmdhd" driver). These ioctls are handled by the "wl_iw_ioctl" function. The function first allocates an "extras" buffer of an appropriate size, according to the ioctl issued. Then, the function looks up the handler function matching the issued ioctl and invokes it, passing the allocated "extras" buffer as an argument.

When the "SIOCGIWESSID" ioctl is invoked (in order to query the current ESSID), the function allocates an extras buffer of size 33, and then invokes the internal handler function, "wl_iw_get_essid". Here is a short snippet from the handler:

1. wl_iw_get_essid(struct net_device *dev, struct iw_request_info *info,
2. struct iw_point *dwrq, char *extra)
3. {
4. wlc_ssid_t ssid;
5. int error;
6. if ((error = dev_wlc_ioctl(dev, WLC_GET_SSID, &ssid, sizeof(ssid)))) {
7. WL_ERROR(("Error getting the SSID\n"));
8. return error;
9. }
10. ssid.SSID_len = dtoh32(ssid.SSID_len);
11. memcpy(extra, ssid.SSID, ssid.SSID_len);
12. ...
13. }

Where "extra" is the extras buffer of size 33, allocated by "wl_iw_ioctl".

As can be seen above, the handler trusts the value of "ssid.SSID_len". An attacker controlling the dongle can re-write the ioctl handling function (since it is entirely RAM-resident), in order to control the results of the ioctl above. This would allow the attacker to return an arbitrarily large value for "ssid.SSID_len", causing the memcpy operation (line 11) to overflow the "extra" buffer.

I've been able to statically verify this issue on the "bcmdhd-3.10" driver, and in the corresponding "bcmdhd" driver on the Nexus 5 (hammerhead) and Nexus 6P's (angler) kernels.

This bug is subject to a 90 day disclosure deadline. If 90 days elapse
without a broadly available patch, then the bug report will automatically
become visible to the public.



Found by: laginimaineb

Comments

RSS Feed Subscribe to this comment feed

No comments yet, be the first!

Login or Register to post a comment

File Archive:

January 2020

  • Su
  • Mo
  • Tu
  • We
  • Th
  • Fr
  • Sa
  • 1
    Jan 1st
    8 Files
  • 2
    Jan 2nd
    11 Files
  • 3
    Jan 3rd
    11 Files
  • 4
    Jan 4th
    2 Files
  • 5
    Jan 5th
    2 Files
  • 6
    Jan 6th
    18 Files
  • 7
    Jan 7th
    15 Files
  • 8
    Jan 8th
    16 Files
  • 9
    Jan 9th
    10 Files
  • 10
    Jan 10th
    13 Files
  • 11
    Jan 11th
    2 Files
  • 12
    Jan 12th
    4 Files
  • 13
    Jan 13th
    21 Files
  • 14
    Jan 14th
    18 Files
  • 15
    Jan 15th
    12 Files
  • 16
    Jan 16th
    18 Files
  • 17
    Jan 17th
    11 Files
  • 18
    Jan 18th
    3 Files
  • 19
    Jan 19th
    2 Files
  • 20
    Jan 20th
    15 Files
  • 21
    Jan 21st
    22 Files
  • 22
    Jan 22nd
    19 Files
  • 23
    Jan 23rd
    0 Files
  • 24
    Jan 24th
    0 Files
  • 25
    Jan 25th
    0 Files
  • 26
    Jan 26th
    0 Files
  • 27
    Jan 27th
    0 Files
  • 28
    Jan 28th
    0 Files
  • 29
    Jan 29th
    0 Files
  • 30
    Jan 30th
    0 Files
  • 31
    Jan 31st
    0 Files

Top Authors In Last 30 Days

File Tags

Systems

packet storm

© 2016 Packet Storm. All rights reserved.

Services
Security Services
Hosting By
Rokasec
close