A A A A A A A A A A A A DefenseCode ThunderScan SAST Advisory A A A A WordPress Simple Login Log Plugin Multiple SQL Injection A A A A A A A A A A A A A A A A A Security Vulnerabilities Advisory ID:A A A DC-2017-01-013 Advisory Title: WordPress Simple Login Log Plugin Multiple SQL A Injection Security Vulnerabilities Advisory URL:A A http://www.defensecode.com/advisories.php Software:A A A A A A WordPress Simple Login Log plugin Language:A A A A A A PHP Version:A A A A A A A 1.1.1 and below Vendor Status:A Vendor contacted, update released Release Date:A A 2017/10/10 Risk:A A A A A A A A A A High 1. General Overview =================== During the security audit of Simple Login Log plugin for WordPress CMS multiple vulnerabilities were discovered using DefenseCode ThunderScan application source code security analysis platform. More information about ThunderScan is available at URL: http://www.defensecode.com 2. Software Overview ==================== According to the authors, this plugin keeps a log of WordPress user logins. It offers user and date filtering, and export features. According to wordpress.org, it has more than 20,000 active installs. Homepage: https://wordpress.org/plugins/simple-login-log/ 3. Vulnerability Description ============================ During the security analysis, ThunderScan discovered two SQL injection vulnerabilities in Simple Login Log WordPress plugin. The easiest way to reproduce the vulnerabilities is to visit the provided URL while being logged in as administrator or another user that is authorized to access the plugin settings page. Users that do not have full administrative privileges could abuse the database access the vulnerability provides to either escalate their privileges or obtain and modify database contents they were not supposed to be able to. Due to the missing nonce token, the attacker the vulnerable code is also directly exposed to attack vectors such as Cross Site request forgery (CSRF). 3.1. SQL injection A Function:A A A A $wpdb->get_results($sql, 'ARRAY_A') A Variable:A A A A $_REQUEST['orderby'] A Sample URL:A A http://vulnerablesite.com/wp-admin/users.php?page=login_log&orderby=1+AND+SLEEP%285%29 A Note:A A A A A A A A Sample URL only works if there is more than one entry in SQL response A File:A A A A A A A A simple-login-log\simple-login-log.php A A A --------- A A A 949 $orderby = (isset($_REQUEST['orderby']) && !empty($_REQUEST['orderby'])) ? $_REQUEST['orderby'] : false; A A A ... A A A 527 $sql = "SELECT * FROM $this->table" . $where . " ORDER BY {$orderby} {$order} " . 'LIMIT ' . $limit . ' OFFSET ' . $offset; A A A --------- 3.2. SQL injection A Function:A A A A $wpdb->get_results($sql, 'ARRAY_A') A Variable:A A A A $_REQUEST['order'] A Sample URL:A A http://vulnerablesite.com/wp-admin/users.php?page=login_log&orderby=time&order=AND+SLEEP%285%29 A Note:A A A A A A A A Sample URL only works if there is more than one entry in SQL response A File:A A A A A A A A simple-login-log\simple-login-log.php A A A --------- A A A 950 $order = (isset($_REQUEST['order']) && !empty($_REQUEST['order'])) ? $_REQUEST['order'] : false; A A A ... A A A 527 $sql = "SELECT * FROM $this->table" . $where . " ORDER BY {$orderby} {$order} " . 'LIMIT ' . $limit . ' OFFSET ' . $offset; A A A --------- A 4. Solution =========== After we reported the vulnerabilities vendor responded that vulnerabilities are fixed and update released. All users are strongly advised to update WordPress Simple Login Log plugin to the latest available version. 5. Credits ========== Discovered by Neven Biruski using DefenseCode ThunderScan source code security analyzer. A 6. Disclosure Timeline ====================== 2017/04/06A A A A A Initial contact 2017/04/17A A A A A Vendor responded 2017/04/28A A A A A Advisory sent to vendor 2017/05/19A A A A A Vendor released an update 2017/10/10A A A A A Advisory released to the public 7. About DefenseCode ==================== DefenseCode L.L.C. delivers products and services designed to analyze and test web, desktop and mobile applications for security vulnerabilities. DefenseCode ThunderScan is a SAST (Static Application Security Testing, WhiteBox Testing) solution for performing extensive security audits of application source code. ThunderScan SAST performs fast and accurate analyses of large and complex source code projects delivering precise results and low false positive rate. DefenseCode WebScanner is a DAST (Dynamic Application Security Testing, BlackBox Testing) solution for comprehensive security audits of active web applications. WebScanner will test a website's security by carrying out a large number of attacks using the most advanced techniques, just as a real attacker would. Subscribe for free software trial on our website http://www.defensecode.com/ . E-mail: defensecode[at]defensecode.com Website: http://www.defensecode.com Twitter: https://twitter.com/DefenseCode/